Adding Hemis Support #274
Open
Adding Hemis Support #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed up my PR due to the fact i put algomodule in requirements.txt but it doesnt need to be in there only in the cirrus_ci.yml. |
SomberNight
reviewed
Sep 16, 2024
|
I will admit, the HemisElectrumX class was not added by me but another person ahmed_bodi i do not know why, i have fixed the other issues specified, Is there something u wish for me to do relating the HemisElectrumX as i dont personally think its needed but i can test to make sure |
|
I have removed it. it doesn't affect the syncing process at all, it functions normal. from what i can see |
|
Actually revert that. it seems its needed due to how our electrum client interacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of hemis